Support pickleability of classes with callable args#728
Merged
mauvilsa merged 7 commits intoJun 10, 2025
Conversation
…e to functools.partial to support pickleability
mauvilsa
requested changes
Jun 7, 2025
mauvilsa
left a comment
mauvilsa
left a comment
Owner
There was a problem hiding this comment.
Thank you, looks good! Just do a small fix in the changelog.
Co-authored-by: Mauricio Villegas <5780272+mauvilsa@users.noreply.github.com>
Contributor
Author
|
@mauvilsa Thank you! I updated the changelog. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #728 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 6859 6857 -2
=========================================
- Hits 6859 6857 -2 ☔ View full report in Codecov by Sentry. |
mauvilsa
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adapt_class_type: Replaced the locally definedpartial_instancewrapper function with afunctools.partialcall to construct class instantiators, ensuring they are compatible with pickle and other serialization libraries.See discussion in #727 for more context.
Before submitting